feat: Update notification handling to prevent account DTO issues; add SystemNotificationService for event notifications

2026-10-25 23:18:44 -07:00 · 2026-07-12 12:43:09 +03:00
parent 63e3b11736
commit 35ef784bd9
6 changed files with 114 additions and 30 deletions
@@ -1054,11 +1054,12 @@ public class RoomsController(
                    EncryptVoiceChat = currentPresence.EncryptVoiceChat,
                },
                isOnline = true,
-                // 2023.03.21 client build version (baked "20230317"). MUST match
-                // the joining client's own version or it reports a version
-                // mismatch and refuses to join. Was a stale December-2020 value
-                // (20201210) carried over when this branch forked.
-                appVersion = 20230317,
+                // 2023.03.21 client build version. MUST be the STRING
+                // "20230317" — the client's presence DTO reads appVersion
+                // with a string reader, so an int crashes the SignalR
+                // message ("expected:'String Begin Token'") and aborts the
+                // update. Must also match the joining client's version.
+                appVersion = "20230317",
            };
            await notifications.NotifyAsync(playerId, PushNotificationId.SubscriptionUpdatePresence, presencePayload);
        }