TheSunIsLeaking/DorkNet
3
0
Fork 0
mirror of https://github.com/DorkSquadRR/DorkNet.git synced 2026-10-25 23:18:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: Revert room-details DTO extras that broke room parsing

Browse Source 
af0d7b6 added RankingContext/DataBlob/MaxPlayers/ToxmodEnabled to the
shared BuildRoomServerDetails (and DataBlobHash/Description to
BuildStudioSaveWire) to try to satisfy the 2023 SaveRoom commit-response
Dispose walk. The invented RankingContext object shape is rejected by
the strict room-details mapper, so GET rooms/{id} (and every room list
that shares the builder) failed with "Malformed Response" -> rooms
broke. The 2023 mappers validate value SHAPES, not just key presence, so
bolting unverified keys onto the shared room DTO is unsafe.

Reverts af0d7b6 code changes. Room saving remains functionally correct
(blob persists, fanout delivers); the SaveRoom success toast is left for
a separately-verified fix.
This commit is contained in:
Alexa
2026-07-08 20:33:39 +03:00
parent af0d7b6c20
commit 479ea273ea
2 changed files with 8 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
DorkNet.Server.Tests/RoomSave2023Tests.cs
+8 -8
View File
@@ -76,21 +76,21 @@ public sealed class RoomSave2023Tests : IClassFixture<DorkNetServerFactory>
using var json = JsonDocument.Parse(responseText);
Assert.True(json.RootElement.GetProperty("success").GetBoolean(), responseText);
// 2023 commit-response contract (NEOPBOMGIOG): value must carry
// BOTH a Room and a SubRoomDataSave or the client's post-parse
// Dispose walk NREs and the watch shows "Failed to save room".
// 2023 commit-response contract (NEOPBOMGIOG): value carries a
// Room and a SubRoomDataSave. The Room reuses the exact GET
// rooms/{id} shape (BuildRoomServerDetails) — do NOT bolt extra
// keys onto it: the room-details mapper is strict about value
// shapes and an invented RankingContext object broke every
// room-details parse ("Malformed Response"). See befd590 revert.
var value = json.RootElement.GetProperty("value");
var roomDto = value.GetProperty("Room");
Assert.Equal(JsonValueKind.Object, roomDto.ValueKind);
// Keys the FGCPNAACHIK mapper reads and its Dispose walk derefs.
foreach (var key in new[] { "RoomId", "DataBlob", "MaxPlayers", "ToxmodEnabled", "RankingContext", "SubRooms", "Roles", "Tags", "Stats" })
foreach (var key in new[] { "RoomId", "SubRooms", "Roles", "Tags", "Stats" })
Assert.True(roomDto.TryGetProperty(key, out _), $"Room missing '{key}': {responseText}");
Assert.Equal(JsonValueKind.Object, roomDto.GetProperty("RankingContext").ValueKind);
var save = value.GetProperty("SubRoomDataSave");
Assert.Equal(blobName, save.GetProperty("DataBlob").GetString());
// Keys the JKIFFPPAJNK save mapper reads.
foreach (var key in new[] { "SubRoomDataSaveId", "SubRoomId", "UnityAssetId", "DataBlobHash", "SavedByAccountId", "Description", "CreatedAt" })
foreach (var key in new[] { "SubRoomDataSaveId", "SubRoomId", "UnityAssetId", "SavedByAccountId", "CreatedAt" })
Assert.True(save.TryGetProperty(key, out _), $"SubRoomDataSave missing '{key}': {responseText}");
await using (var scope = _factory.Services.CreateAsyncScope())