fix: presence, profile edits, outfit menu and RecNetResult writes for the 2023 client

Every change below was checked against the 2023-03-21 client disassembly;
file:line evidence is in the code comments and in
docs/recroom-2023-client-api-complete.md.

Presence
- matchmake/none means "online, in no room" (its only caller is
  TryGoToOfflineRoom, which ignores the reply). The server used to keep the
  old room or invent a dorm, so the next heartbeat looked out of sync and
  the client cancelled its load to chase that room.
- The join watchdog no longer clears presence 30 s into a long room load;
  it is a 3 minute backstop that drops the room only.
- One fan-out (PresenceBroadcastService) for every transition: deferred
  joins, matchmake/none, logout, failed joins, visibility changes, SignalR
  connect/disconnect. isOnline is sent on its own; pushes never go to the
  subject, because a self push moves the player.
- Online-status visibility (Public / Friends / Favorites / Appear offline)
  is stored and honoured by GET /player and by the live pushes.

Profile
- PUT account/me/{emoji,personalpronouns,identityflags,bannerimage} were
  404; added with the client's real form keys and persisted (new Players
  columns plus migration). Every account read now returns them, and edits
  push AccountUpdate to everyone.

Outfit menu
- Saved outfits kept OutfitSelectionsV2 and CustomAvatarItems, so loading a
  slot restores what was saved instead of a stale outfit.
- isCreationAllowedForAccount answers the {Success, Error} envelope the
  client parses; minPriceForPublicItem is a bare int; gifts/generate accepts
  form bodies; lockeditems returns the full owned-item shape; colourways no
  longer share their base item's AvatarItemId.

RecNetResult writes
- About 40 writes look status-only but parse the body as {Success, Error}.
  An empty 200 showed "Failed to ..." after the server applied the change,
  and a body without Success threw "Error message cannot be null". Clubs,
  announcements, keepsakes, comments/read, subscriptions, purchase offers
  and privacy settings now answer RecNetResult.
- Login token and device-code grants are real; remoteauth approves the
  device code; createlogintoken returns a bare string.
- New: incentivizedreferrals/referrals, account/bulk/{email,phone},
  GET strings, account/me/confirmphone, PlayMenuCarouselOrdering_1.
  Route inventory and coverage test extended to match.

README now describes the 2023 branch.

DorkNet.Server/Hubs/NotifyHub.cs

@@ -42,8 +42,7 @@ public class NotifyHub(
     OnlinePresenceService presence,
     PlayerPresenceService playerRooms,
     NotificationService notifications,
-    DorkNetDbContext db,
-    ServerSettingsService serverSettings,
+    PresenceBroadcastService presenceFanout,
     ILogger<NotifyHub> logger) : Hub
 {
     /// <summary>SignalR group name for a given player id. Use this
@@ -108,18 +107,11 @@ public class NotifyHub(
             // friend's list for the rest of the session even though they were
             // still playing.
             //
-            // Only push when a room is already known. The presence payload
-            // derives isOnline from roomInstance being non-null, so a push with
-            // no room reads as OFFLINE — worse than staying quiet. On a fresh
-            // boot there is no room yet and the /goto that follows sends the
-            // real presence anyway; this branch is for reconnects, where the
-            // cached room is exactly what friends need to see again.
-            if (cameOnline && playerRooms.GetRoom(id) is { } room)
-            {
-                var friendIds = await RelationshipQueries.EffectiveFriendIdsAsync(db, serverSettings, id);
-                if (friendIds.Count > 0)
-                    await notifications.PlayerCameOnline(friendIds, id, room);
-            }
+            // isOnline is sent explicitly now, so this no longer needs a
+            // known room: a player who connects before matchmaking, or who is
+            // sitting in the offline room, is online with roomInstance null.
+            if (cameOnline)
+                await presenceFanout.PublishCurrentAsync(id);
         }
         else
         {
@@ -139,9 +131,17 @@ public class NotifyHub(
             await Groups.RemoveFromGroupAsync(Context.ConnectionId, GroupForPlayer(id));
             if (wentOffline)
             {
-                var friendIds = await RelationshipQueries.EffectiveFriendIdsAsync(db, serverSettings, id);
-                if (friendIds.Count > 0)
-                    await notifications.PlayerWentOffline(friendIds, id);
+                // The socket can drop under a live session (the server or a
+                // proxy closes it; the client logs "RecNet HubConnection error:
+                // ... TCP Stream closed unexpectedly by the remote server" and
+                // reconnects by itself). While the player is still
+                // heartbeating, wait one activity window before calling them
+                // offline; a real exit either logs out (immediate offline push)
+                // or stops heartbeating and is caught by the deferred check.
+                if (playerRooms.IsRecentlyActive(id))
+                    presenceFanout.ScheduleOfflineCheck(id);
+                else
+                    await presenceFanout.PublishOfflineAsync(id);
             }
             logger.LogInformation(
                 "[hub] disconnected player={PlayerId} conn={ConnectionId} wentOffline={WentOffline} error={Error}",