fix: presence, profile edits, outfit menu and RecNetResult writes for the 2023 client

Every change below was checked against the 2023-03-21 client disassembly;
file:line evidence is in the code comments and in
docs/recroom-2023-client-api-complete.md.

Presence
- matchmake/none means "online, in no room" (its only caller is
  TryGoToOfflineRoom, which ignores the reply). The server used to keep the
  old room or invent a dorm, so the next heartbeat looked out of sync and
  the client cancelled its load to chase that room.
- The join watchdog no longer clears presence 30 s into a long room load;
  it is a 3 minute backstop that drops the room only.
- One fan-out (PresenceBroadcastService) for every transition: deferred
  joins, matchmake/none, logout, failed joins, visibility changes, SignalR
  connect/disconnect. isOnline is sent on its own; pushes never go to the
  subject, because a self push moves the player.
- Online-status visibility (Public / Friends / Favorites / Appear offline)
  is stored and honoured by GET /player and by the live pushes.

Profile
- PUT account/me/{emoji,personalpronouns,identityflags,bannerimage} were
  404; added with the client's real form keys and persisted (new Players
  columns plus migration). Every account read now returns them, and edits
  push AccountUpdate to everyone.

Outfit menu
- Saved outfits kept OutfitSelectionsV2 and CustomAvatarItems, so loading a
  slot restores what was saved instead of a stale outfit.
- isCreationAllowedForAccount answers the {Success, Error} envelope the
  client parses; minPriceForPublicItem is a bare int; gifts/generate accepts
  form bodies; lockeditems returns the full owned-item shape; colourways no
  longer share their base item's AvatarItemId.

RecNetResult writes
- About 40 writes look status-only but parse the body as {Success, Error}.
  An empty 200 showed "Failed to ..." after the server applied the change,
  and a body without Success threw "Error message cannot be null". Clubs,
  announcements, keepsakes, comments/read, subscriptions, purchase offers
  and privacy settings now answer RecNetResult.
- Login token and device-code grants are real; remoteauth approves the
  device code; createlogintoken returns a bare string.
- New: incentivizedreferrals/referrals, account/bulk/{email,phone},
  GET strings, account/me/confirmphone, PlayMenuCarouselOrdering_1.
  Route inventory and coverage test extended to match.

README now describes the 2023 branch.
This commit is contained in:
Alexa
2026-10-15 14:08:11 +03:00
parent 36e64e99ba
commit 6ee1d6f9b3
45 changed files with 6666 additions and 448 deletions
@@ -523,3 +523,45 @@ POST thread/{0}/snooze social-clubs-chat
GET unity_assets/{0}/{1}/{2} inventions-media
GET voice/config moderation-safety
GET voice/requiresModeration moderation-safety
# Requests the plain route-literal sweep missed. Each verified in the ISIL:
# - leading-slash literals (RecNet.Runtime): LCOCDKINDMN_NestedType_CIPKPLFLIPC.txt:218,
# PBOGNAPEBAI_NestedType_JKNCNOHGPHK.txt:251 (GET under 100 ids, POST at 100+),
# NHILNDLLLHH.txt:329/801, OKOOJMAOKFE.txt:561, MNANGNGKKDA_NestedType_JAMKPNKPJPD.txt:179
# - Assembly-CSharp CDN fetch: JFDPIJFDHAD.txt:1432 (/sigs/<id>, boot file-signature check)
# - DELETE subscription/{0}: IKMMOCKDKAF.txt LPFOPPHGDHG (verb 4)
# - account/me/{field}: composed at runtime by OPMAPIOEIFG.OBAGJBBIFGB("account/me/" + field);
# verbs from each caller (username/displayname/bio/birthday/emoji/personalpronouns/identityflags/bannerimage PUT=3,
# email/phone/confirmphone POST=2).
GET api/playerReputation/v2/bulk identity-account
POST api/playerReputation/v2/bulk identity-account
GET api/players/v2/progression/bulk identity-account
POST api/players/v2/progression/bulk identity-account
GET strings config-telemetry
GET config/{0} config-telemetry
GET data/{0} config-telemetry
GET sigs/{0} config-telemetry
DELETE subscription/{0} commerce-subscription
PUT account/me/username identity-account
PUT account/me/displayname identity-account
PUT account/me/bio identity-account
PUT account/me/birthday identity-account
POST account/me/email identity-account
POST account/me/phone identity-account
PUT account/me/emoji identity-account
PUT account/me/personalpronouns identity-account
PUT account/me/identityflags identity-account
PUT account/me/bannerimage identity-account
POST account/me/confirmphone identity-account
# Routes composed from a base literal plus a format/segment (BPAIBFBKKCN.txt:51-53, HPEBLAHNBLC.txt:38-40,
# and the LPPEFJMCJFN URL builder in LINKIECPDML.txt:677-737).
GET api/itemWishlists/v1/wishlist/me avatar-inventory
GET api/itemWishlists/v1/wishlist/{0} avatar-inventory
PUT api/itemWishlists/v1/wishlist/me/{0} avatar-inventory
DELETE api/itemWishlists/v1/wishlist/me/{0} avatar-inventory
GET api/roomEarningsDistributions/v1/earningsDistribution/{0} progression-misc
GET api/incentivizedreferrals/referrals progression-misc
# Contact lookup (OPMAPIOEIFG.txt:11590-11620) and composed paths (FFFIMAGLKEG.txt:137, NOGJJIIENIL.txt:29).
POST account/bulk/email identity-account
POST account/bulk/phone identity-account
POST api/avatar/v2/gifts/consume avatar-inventory
GET video/{0} config-telemetry
Can't render this file because it contains an unexpected character in line 532 and column 73.