Merge pull request #20 from DorkSquadRR/fix/steamless-download-404

launcher: fix Steamless download 404

.github/workflows/release-launcher.yml

@@ -126,10 +126,10 @@ jobs:
             -c Release \
             -r "${{ matrix.rid }}" \
             --self-contained true \
-            /p:Version="$v" \
-            /p:AssemblyVersion="${v}.0" \
-            /p:FileVersion="${v}.0" \
-            /p:InformationalVersion="$v"
+            -p:Version="$v" \
+            -p:AssemblyVersion="${v}.0" \
+            -p:FileVersion="${v}.0" \
+            -p:InformationalVersion="$v"
 
       - name: Package
         shell: bash

cli/DorkNet.ServerCli/DorkNet.ServerCli.csproj

@@ -6,6 +6,10 @@
          alongside Windows. The shared Backend classes are written to
          OperatingSystem.IsWindows()-gate any Windows-only paths. -->
     <TargetFramework>net9.0</TargetFramework>
+    <!-- Declared so a RID-less restore produces assets for every target the
+         CI matrix / release pipeline later publishes with no-restore. Without
+         this, RID-specific publish fails with NETSDK1047. -->
+    <RuntimeIdentifiers>win-x64;linux-x64;linux-arm64;osx-x64;osx-arm64</RuntimeIdentifiers>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <RootNamespace>DorkNet.ServerCli</RootNamespace>

cli/DorkNet.ServerCli/Program.cs

@@ -14,8 +14,15 @@ public static class Program
 {
     public static async Task<int> Main(string[] args)
     {
+        // --help / -h (and a bare invocation) print usage and exit cleanly.
+        if (args.Length == 0 || args.Contains("--help") || args.Contains("-h"))
+        {
+            PrintHelp();
+            return 0;
+        }
+
         var parsed = ParseArgs(args);
-        if (parsed is null) return 1; // ParseArgs already wrote --help or an error.
+        if (parsed is null) return 1; // ParseArgs already wrote the error.
 
         // Validate required values up front so the user sees the
         // failure before any download / process spin-up.
@@ -216,17 +223,13 @@ public static class Program
 
     private static ParsedArgs? ParseArgs(string[] args)
     {
-        if (args.Length == 0 || args.Contains("--help") || args.Contains("-h"))
-        {
-            PrintHelp();
-            return null;
-        }
-
         string photon = "", voice = "", region = "us";
         string mode = "localtunnel", apex = "", name = "DorkNet Server";
         string versionKey = "march_2020_03_10";
         string? serverDir = null;
 
+        try
+        {
             for (int i = 0; i < args.Length; i++)
             {
                 string Next()
@@ -261,6 +264,12 @@ public static class Program
 
             return new ParsedArgs(photon, voice, region, parsedMode, apex, name, versionKey, serverDir);
         }
+        catch (ArgumentException ex)
+        {
+            Console.Error.WriteLine($"error: {ex.Message} (try --help)");
+            return null;
+        }
+    }
 
     private static void PrintHelp()
     {

docs/photon-setup.md

@@ -29,8 +29,6 @@ Go to **[dashboard.photonengine.com](https://dashboard.photonengine.com/)**
 and click "Sign up". Email + password; the free tier doesn't ask for a
 card.
 
-![photon dashboard signup screen](images/photon-1-signup.png)
-
 > If you already have an account from another project, log in instead.
 > Multiple DorkNet servers can share the same Photon account, but each
 > server needs its own AppId pair so concurrent player counts don't
@@ -49,15 +47,11 @@ for:
 
 Click **CREATE**.
 
-![photon "Create a new app" form, Photon SDK selected](images/photon-2-create-realtime.png)
-
 ## Step 3 — Copy the Realtime AppId
 
 You land back on the dashboard with your new app at the top. The AppId
 is the long string under the app name — click it to copy.
 
-![photon app card with AppId highlighted](images/photon-3-realtime-appid.png)
-
 That's your **Realtime AppId**. Paste it into:
 
 - the launcher's first-run wizard step 4, **REALTIME APPID** field, OR
@@ -69,8 +63,6 @@ That's your **Realtime AppId**. Paste it into:
 If you want in-game voice chat, repeat Step 2 with **Photon Voice**
 selected instead of Realtime. Same flow.
 
-![photon "Create a new app" form, Voice selected](images/photon-4-create-voice.png)
-
 Copy the Voice AppId from the dashboard the same way as Step 3 and
 paste it into:
 

launcher/Backend/SteamlessInstaller.cs

@@ -22,9 +22,12 @@ namespace DorkNet.Launcher.Backend;
 public static class SteamlessInstaller
 {
     private const string PinnedVersion = "v3.1.0.5";
+    // Upstream names the asset "Steamless.{ver}.-.by.atom0s.zip" — NOT
+    // "Steamless.{ver}.zip". Getting this wrong is a 404 at the
+    // "Unlock Rec Room from Steam" step.
     private const string ZipUrl =
         "https://github.com/atom0s/Steamless/releases/download/" +
-        PinnedVersion + "/Steamless." + PinnedVersion + ".zip";
+        PinnedVersion + "/Steamless." + PinnedVersion + ".-.by.atom0s.zip";
 
     private static readonly HttpClient Http = new()
     {