mirror of
https://github.com/DorkSquadRR/DorkNet.git
synced 2026-10-25 15:08:47 -07:00
Alexa
327dcb789c
Audits every route the March-2023 client can call against what this server
actually serves, and fixes the defects that were breaking gameplay. Adds
docs/recroom-2023-client-api-complete.md as the reference: ~500 route
literals across 13 subsystems, with verb, request/response shape, and a
per-subsystem diff. 315 defects catalogued; the ones fixed here are listed
in its "Already fixed" table.
Path coverage was never the problem — 465 of 506 routes already had
handlers. The failures were in shape, and they cluster into four causes:
- Wrong verb. The verb is a BestHTTP.HTTPMethods ordinal (GET=0 .. PATCH=5),
confirmed from that enum's static constructor. Routes registered POST-only
while the client PUTs returned 405, which made room consumables neither
buyable nor consumable and blocked every room-key edit.
- Bare scalar wrapped in an object. The client reads `1000`, not
`{"Limit":1000}`; the issuing method signature says which. Wrapping makes
the deserializer throw and the feature dies silently.
- [FromBody] vs form-urlencoded. The client sends nearly every write as form
data, which an [ApiController] action bound [FromBody] rejects with 415
before the handler runs. This alone broke all 13 club member-management
endpoints. Adds Binding/FormOrJsonModelBinder so this is fixed once.
- Notify dispatch keys. Both enum overloads of the client's RegisterHandler
lower the id via Int32.ToString() and register only that numeric key, and
lookup is a case-sensitive TryGetValue that returns silently on a miss. We
were sending the enum NAME for most ids, so friend-request updates, forced
logout, maintenance broadcasts, live balance and consumable updates, and
invention moderation pushes all evaporated with no error anywhere.
Notable behavioural bugs fixed:
- Editing a club announcement deleted it: PUT was a third binding on the
delete handler. Split apart, and the missing create route added.
- leaderboard/CheckAndSetStat did not exist. The 2023 client has no SetStat
literal at all, so every leaderboard score it wrote was discarded.
- Setting a club clubhouse cleared it: the handler read roomId from the query
while the client sends it in the body, then wrote the resulting null.
- Club join requests were inverted (the enum is Open=0, InviteOnly=1,
AskToJoin=2), so ask-to-join clubs rejected everyone and invite-only clubs
quietly admitted them.
- Room bans were pushed as id 24, for which the client registers no handler;
they now go out as ModerationKick with IsBan, so the ban takes effect
immediately instead of at next login.
- Room-key ownership queries answered for the wrong player, and "has anyone
bought this key" asked "did I buy it" — always false for the creator.
Also persists settings that were previously acknowledged and dropped
(playlist accessibility/restrictions/level-voting/warning, per-player status
visibility, VR movement mode and avoid-juniors, custom room codes), which is
what the new columns in the migration are for.
One test asserted the old nested PriceAndCurrency response shape; the
client's consumable formatter has no such key and reads Price and
PurchaseCurrencyId flat, so the test was corrected alongside the handler.
87 lines
3.1 KiB
C#
87 lines
3.1 KiB
C#
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using DorkNet.Models.Players;
|
|
using DorkNet.Server.Auth;
|
|
using DorkNet.Server.Services;
|
|
|
|
namespace DorkNet.Server.Controllers.API.Players.V2;
|
|
|
|
[ApiController]
|
|
[Route("api/[controller]/v2")]
|
|
[Authorize]
|
|
public class PlayersController(PlayerService playerService, NotificationService notificationService) : ControllerBase
|
|
{
|
|
private long CurrentPlayerId => this.RequireCurrentPlayerId();
|
|
|
|
[HttpGet("me")]
|
|
public async Task<ActionResult<PlayerProfile>> GetSelf()
|
|
{
|
|
var player = await playerService.GetByIdAsync(CurrentPlayerId);
|
|
if (player is null) return NotFound();
|
|
return Ok(PlayerService.ToProfile(player));
|
|
}
|
|
|
|
// The 2023 client PUTs this right after setting an email; GET-only meant a
|
|
// 405 on every contact-preferences write.
|
|
[HttpPut("/api/players/v4/current/contact")]
|
|
[HttpGet("/api/players/v4/current/contact")]
|
|
public async Task<IActionResult> CurrentContact()
|
|
{
|
|
var player = await playerService.GetByIdAsync(CurrentPlayerId);
|
|
if (player is null) return NotFound();
|
|
return Ok(new
|
|
{
|
|
AccountId = (int)player.Id,
|
|
Email = player.Email ?? string.Empty,
|
|
Phone = player.Phone ?? string.Empty,
|
|
CanReceiveInvites = player.CanReceiveInvites,
|
|
});
|
|
}
|
|
|
|
[HttpGet("{id:long}")]
|
|
public async Task<ActionResult<PlayerProfile>> GetById(long id)
|
|
{
|
|
var player = await playerService.GetByIdAsync(id);
|
|
if (player is null) return NotFound();
|
|
return Ok(PlayerService.ToProfile(player));
|
|
}
|
|
|
|
[HttpGet("search")]
|
|
public async Task<ActionResult<List<PlayerProfile>>> Search([FromQuery] string query)
|
|
{
|
|
if (string.IsNullOrWhiteSpace(query)) return Ok(new List<PlayerProfile>());
|
|
var results = await playerService.SearchAsync(query);
|
|
return Ok(results.Select(PlayerService.ToProfile).ToList());
|
|
}
|
|
|
|
[HttpPost("displayName")]
|
|
public async Task<ActionResult<PlayerProfile>> UpdateDisplayName([FromForm] string? DisplayName)
|
|
{
|
|
if (string.IsNullOrWhiteSpace(DisplayName))
|
|
return BadRequest("DisplayName is required");
|
|
|
|
var updated = await playerService.UpdateDisplayNameAsync(CurrentPlayerId, DisplayName);
|
|
if (!updated) return NotFound();
|
|
|
|
var player = await playerService.GetByIdAsync(CurrentPlayerId);
|
|
await notificationService.AccountChanged(player!);
|
|
return Ok(PlayerService.ToProfile(player!));
|
|
}
|
|
|
|
[HttpPut("{id:long}")]
|
|
public async Task<ActionResult<PlayerProfile>> UpdateProfile(long id, [FromBody] UpdateProfileRequest req)
|
|
{
|
|
if (id != CurrentPlayerId) return Forbid();
|
|
|
|
if (req.DisplayName is not null)
|
|
await playerService.UpdateDisplayNameAsync(id, req.DisplayName);
|
|
|
|
if (req.Bio is not null)
|
|
await playerService.UpdateBioAsync(id, req.Bio);
|
|
|
|
var player = await playerService.GetByIdAsync(id);
|
|
await notificationService.AccountChanged(player!);
|
|
return Ok(PlayerService.ToProfile(player!));
|
|
}
|
|
}
|