mirror of
https://github.com/DorkSquadRR/DorkNet.git
synced 2026-10-26 07:28:45 -07:00
Alexa
327dcb789c
Audits every route the March-2023 client can call against what this server
actually serves, and fixes the defects that were breaking gameplay. Adds
docs/recroom-2023-client-api-complete.md as the reference: ~500 route
literals across 13 subsystems, with verb, request/response shape, and a
per-subsystem diff. 315 defects catalogued; the ones fixed here are listed
in its "Already fixed" table.
Path coverage was never the problem — 465 of 506 routes already had
handlers. The failures were in shape, and they cluster into four causes:
- Wrong verb. The verb is a BestHTTP.HTTPMethods ordinal (GET=0 .. PATCH=5),
confirmed from that enum's static constructor. Routes registered POST-only
while the client PUTs returned 405, which made room consumables neither
buyable nor consumable and blocked every room-key edit.
- Bare scalar wrapped in an object. The client reads `1000`, not
`{"Limit":1000}`; the issuing method signature says which. Wrapping makes
the deserializer throw and the feature dies silently.
- [FromBody] vs form-urlencoded. The client sends nearly every write as form
data, which an [ApiController] action bound [FromBody] rejects with 415
before the handler runs. This alone broke all 13 club member-management
endpoints. Adds Binding/FormOrJsonModelBinder so this is fixed once.
- Notify dispatch keys. Both enum overloads of the client's RegisterHandler
lower the id via Int32.ToString() and register only that numeric key, and
lookup is a case-sensitive TryGetValue that returns silently on a miss. We
were sending the enum NAME for most ids, so friend-request updates, forced
logout, maintenance broadcasts, live balance and consumable updates, and
invention moderation pushes all evaporated with no error anywhere.
Notable behavioural bugs fixed:
- Editing a club announcement deleted it: PUT was a third binding on the
delete handler. Split apart, and the missing create route added.
- leaderboard/CheckAndSetStat did not exist. The 2023 client has no SetStat
literal at all, so every leaderboard score it wrote was discarded.
- Setting a club clubhouse cleared it: the handler read roomId from the query
while the client sends it in the body, then wrote the resulting null.
- Club join requests were inverted (the enum is Open=0, InviteOnly=1,
AskToJoin=2), so ask-to-join clubs rejected everyone and invite-only clubs
quietly admitted them.
- Room bans were pushed as id 24, for which the client registers no handler;
they now go out as ModerationKick with IsBan, so the ban takes effect
immediately instead of at next login.
- Room-key ownership queries answered for the wrong player, and "has anyone
bought this key" asked "did I buy it" — always false for the creator.
Also persists settings that were previously acknowledged and dropped
(playlist accessibility/restrictions/level-voting/warning, per-player status
visibility, VR movement mode and avoid-juniors, custom room codes), which is
what the new columns in the migration are for.
One test asserted the old nested PriceAndCurrency response shape; the
client's consumable formatter has no such key and reads Price and
PurchaseCurrencyId flat, so the test was corrected alongside the handler.
69 lines
3.3 KiB
C#
69 lines
3.3 KiB
C#
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using DorkNet.Server.Auth;
|
|
using DorkNet.Server.Data;
|
|
using DorkNet.Server.Data.Entities;
|
|
|
|
namespace DorkNet.Server.Controllers.API.ScreenShareReports;
|
|
|
|
[ApiController]
|
|
[Authorize]
|
|
public class ScreenShareReportsController(DorkNetDbContext db) : ControllerBase
|
|
{
|
|
/// <summary>Screen-share (photo) report. The 2023-03-21 client posts the
|
|
/// form keys <c>ImageName</c>, <c>ReportedPlayerId</c>, <c>RoomId</c>,
|
|
/// <c>RoomInstanceId</c>, <c>RoomInstanceType</c> and <c>Details</c>
|
|
/// (RecNet.Runtime/KAEAEIODGBG.txt:281-360). It sends no
|
|
/// <c>reportCategory</c> at all.
|
|
///
|
|
/// The old signature bound <c>targetPlayerId</c>, so the reported player
|
|
/// was stored as 0 on every screen-share report and the reported image was
|
|
/// dropped entirely — the report was unactionable. Form binding is
|
|
/// case-insensitive, so <c>RoomId</c>/<c>Details</c> did land; the names
|
|
/// that differ are the ones spelled out explicitly below.</summary>
|
|
[HttpPost("api/screensharereports/v1/report")]
|
|
public async Task<IActionResult> Report(
|
|
[FromForm(Name = "ReportedPlayerId")] long? reportedPlayerId,
|
|
[FromForm] long? targetPlayerId,
|
|
[FromForm] long? roomId,
|
|
[FromForm(Name = "RoomInstanceId")] long? roomInstanceId,
|
|
[FromForm(Name = "RoomInstanceType")] int? roomInstanceType,
|
|
[FromForm(Name = "ImageName")] string? imageName,
|
|
[FromForm] int? reportCategory,
|
|
[FromForm] string? details)
|
|
{
|
|
var reporter = this.RequireCurrentPlayerId();
|
|
var target = reportedPlayerId
|
|
?? targetPlayerId
|
|
?? (long.TryParse(Request.Query["ReportedPlayerId"].FirstOrDefault()
|
|
?? Request.Query["targetPlayerId"].FirstOrDefault(), out var qTarget) ? qTarget : 0);
|
|
var room = roomId
|
|
?? (long.TryParse(Request.Query["roomId"].FirstOrDefault(), out var qRoom) ? qRoom : 0);
|
|
// The client never sends a category for screen-share reports; 5 is the
|
|
// server's existing "other" bucket.
|
|
var category = reportCategory
|
|
?? (int.TryParse(Request.Query["reportCategory"].FirstOrDefault(), out var qCategory) ? qCategory : 5);
|
|
var message = details ?? Request.Query["details"].FirstOrDefault() ?? string.Empty;
|
|
|
|
// Keep the evidence (image + instance) in the stored text: ReportEntity
|
|
// has no dedicated columns for them and a report without the offending
|
|
// image is not actionable by a moderator.
|
|
var context = new List<string>();
|
|
if (!string.IsNullOrWhiteSpace(imageName)) context.Add($"image={imageName}");
|
|
if (roomInstanceId is > 0) context.Add($"instance={roomInstanceId}");
|
|
if (roomInstanceType is not null) context.Add($"instanceType={roomInstanceType}");
|
|
if (context.Count > 0) message = $"[screenshare {string.Join(' ', context)}] {message}".Trim();
|
|
|
|
db.Reports.Add(new ReportEntity
|
|
{
|
|
ReporterPlayerId = reporter,
|
|
TargetPlayerId = target,
|
|
RoomId = room,
|
|
Category = category,
|
|
Message = message[..Math.Min(1000, message.Length)],
|
|
});
|
|
await db.SaveChangesAsync();
|
|
return Ok(new { Success = true, Error = string.Empty });
|
|
}
|
|
}
|