mirror of
https://github.com/DorkSquadRR/DorkNet.git
synced 2026-10-25 15:08:47 -07:00
Alexa
cc523181d2
Both bugs were the same shape: we answered HTTP 200 with a key set the client's generated reader did not agree with, the reader threw mid-deserialise, and it surfaced later as a bare "Failed to copy room" / a chat that never opened, with no URL in the client log and no payload in the server log. Rather than guess at fields, tools/extract-client-dto-keys.py reads the readers out of the ISIL dump. Cpp2IL emits each generated reader's property names as string literals in registration order (three spellings per field: Pascal, camel, lower), so the extracted catalogue is the client's own contract. 156 reader types land in DorkNet.Server.Tests/data/client-dto-keys-2023.json, and ClientDtoParityTests asserts our real responses against them — nothing missing, nothing extra. Chat (EKEFFNBIOHJ) was missing exactly one key: LatestMessage. It was only emitted when a thread HAD messages, so it vanished from the one response where it was needed — the thread that thread/withmembers has just created, which by definition has none. It is now always present, null when there is nothing to report; a registered slot wants a value and an absent key is not one. Room details (GLEGPFFPDBE) was missing DataBlob, DataBlobHash, MaxPlayers, ToxmodEnabled and RankingContext, and sent 15 keys the reader has no slot for. The 15 are gone: UgcVersion, UgcSubVersion, MinUgcSubVersion, PublishState, PublishStateAvailability, BoostCount, ExcludeFromLists, IsJuniorCreated, IsRecRoomApproved, IsRoomLinkedToRecRoomStudio, IsStudioRoom, StudioSessionId, RestrictedCircuitsAllowListNames, AllowNewUsers, AllowsNewUsers. That deletion also removes a comment asserting the 2023 client reads UgcVersion to build its asset-bundle URL. It does not — the literal appears nowhere in the entire decompile, and neither do PublishState or BoostCount.