add version check for 20230414 client

apps/api/src/openapi.ts

@@ -135,9 +135,9 @@ export const ApiConfigV2 = JsonObject.describe(
 	'The static client config, plus a ShareBaseUrl templated from the deploy domain'
 )
 
-/** `GET /api/versioncheck/v4` — always the "you are up to date" answer. */
+/** `GET /api/versioncheck/v4` — whether the client's `?v=` build matches GAME_VERSION. */
 export const VersionCheck = z.object({
-	VersionStatus: z.int().describe('0 = current'),
+	VersionStatus: z.int().describe('0 = current, 1 = client on a different build'),
 	UpdateNotificationStage: z.int(),
 	IsVersionIslanded: z.boolean(),
 	IsCrossPlayDisabled: z.boolean(),

apps/api/src/routes/config.ts

@@ -1,6 +1,8 @@
 import { Hono } from 'hono'
 import { describeRoute } from 'hono-openapi'
 
+import { GAME_VERSION } from '@repo/domain'
+
 import apiConfigV2 from '../../static/api-config-v2.json'
 import gameConfigsV1All from '../../static/gameconfigs-v1-all.json'
 import {
@@ -97,13 +99,14 @@ export const configRoutes = new Hono<App>({ strict: false })
 			tags: ['Config'],
 			summary: 'Client version check',
 			description:
-				'Whether the client build is current. Always the “up to date, nothing islanded” ' +
-				'answer — this server does not gate on client version.',
-			responses: { 200: json(VersionCheck, 'Always current') },
+				'Whether the client build is current. Compares the client’s `?v=` build against ' +
+				'our target `GAME_VERSION`: `VersionStatus` is 0 when they match, 1 when the ' +
+				'client is on a different build.',
+			responses: { 200: json(VersionCheck, 'Version status') },
 		}),
 		(c) =>
 			c.json({
-				VersionStatus: 0,
+				VersionStatus: c.req.query('v') === GAME_VERSION ? 0 : 1,
 				UpdateNotificationStage: 0,
 				IsVersionIslanded: false,
 				IsCrossPlayDisabled: false,

apps/api/src/test/integration/api.test.ts

@@ -2,6 +2,8 @@ import { adminSecretsStore, env } from 'cloudflare:test'
 import { exports } from 'cloudflare:workers'
 import { beforeAll, describe, expect, test } from 'vitest'
 
+import { GAME_VERSION } from '@repo/domain'
+
 import '../../api.app'
 
 import { createImage, getImageByName, SCHEMA_DDL as IMAGES_SCHEMA_DDL } from '../../images-db'
@@ -135,11 +137,16 @@ describe('public endpoints', () => {
 		expect(body).toMatchObject({ ReportBudget: 125, VersionRegex: '.*' })
 	})
 
-	test('GET /api/versioncheck/v4', async () => {
-		const res = await exports.default.fetch(`${ORIGIN}/api/versioncheck/v4`)
+	test('GET /api/versioncheck/v4 reports current for the matching build', async () => {
+		const res = await exports.default.fetch(`${ORIGIN}/api/versioncheck/v4?v=${GAME_VERSION}`)
 		expect(await res.json()).toMatchObject({ VersionStatus: 0 })
 	})
 
+	test('GET /api/versioncheck/v4 flags a mismatched build', async () => {
+		const res = await exports.default.fetch(`${ORIGIN}/api/versioncheck/v4?v=19990101`)
+		expect(await res.json()).toMatchObject({ VersionStatus: 1 })
+	})
+
 	test('GET /api/relationships/v2/get returns empty array for a player with none', async () => {
 		const res = await exports.default.fetch(`${ORIGIN}/api/relationships/v2/get`, {
 			headers: await bearer('99999'),

apps/auth/src/auth.app.ts

@@ -6,6 +6,7 @@ import {
 	countAccountsByPlatformId,
 	countAccountsBySignupIp,
 	createAccount,
+	GAME_VERSION,
 	getAccount,
 	getAccountByUsername,
 	getAccountsByPlatformId,
@@ -139,7 +140,7 @@ async function placeNewPlayerInOrientation(
 		deviceClass,
 		vrMovementMode: 1,
 		platform: 0,
-		appVersion: '20230302',
+		appVersion: GAME_VERSION,
 	})
 }
 

apps/match/src/match.app.ts

@@ -7,6 +7,7 @@ import {
 	createRoomInstance,
 	deleteExpiredPresence,
 	deletePresence,
+	GAME_VERSION,
 	getAccount,
 	getClubSummary,
 	getExpiredPresenceInstanceIds,
@@ -140,13 +141,6 @@ type Presence = StoredPresence<RoomInstance>
  */
 const PRESENCE_REFRESH_THRESHOLD = 300
 
-/**
- * Game build version reported in presence. This is a server-side constant — the
- * client doesn't supply it, and an empty value breaks the client's
- * presence/version handling. Matches our target 2023 client build.
- */
-const GAME_VERSION = '20230302'
-
 /**
  * Default `/player` payload, served whenever the `id` is missing/invalid or the
  * account isn't found. Inlined here (Workers have no filesystem). The stub player

apps/match/src/test/integration/api.test.ts

@@ -10,6 +10,7 @@ import { beforeAll, describe, expect, test } from 'vitest'
 
 import {
 	countPlayersInInstance,
+	GAME_VERSION,
 	getRoomInstance,
 	PRESENCE_SCHEMA_DDL,
 	ROOM_INSTANCE_SCHEMA_DDL,
@@ -200,7 +201,7 @@ describe('public endpoints', () => {
 		// fields, which only ever carry values in a matchmaking response.
 		expect(await res.json()).toEqual([
 			{
-				appVersion: '20230302',
+				appVersion: GAME_VERSION,
 				deviceClass: 0,
 				errorCode: 0,
 				isOnline: false,
@@ -234,7 +235,7 @@ describe('public endpoints', () => {
 		const res = await exports.default.fetch(`${ORIGIN}/player`)
 		expect(res.status).toBe(200)
 		const players = (await res.json()) as Array<{ playerId: number; isOnline: boolean }>
-		expect(players[0]).toMatchObject({ playerId: 1, isOnline: true, appVersion: '20230302' })
+		expect(players[0]).toMatchObject({ playerId: 1, isOnline: true, appVersion: GAME_VERSION })
 	})
 
 	test('POST /goto/none returns the offline dorm', async () => {
@@ -702,7 +703,7 @@ describe('auth-gated endpoints', () => {
 					deviceClass: 0,
 					vrMovementMode: 1,
 					platform: 0,
-					appVersion: '20230302',
+					appVersion: GAME_VERSION,
 					expiresAt,
 				})
 			)
@@ -761,7 +762,7 @@ describe('auth-gated endpoints', () => {
 						deviceClass: 0,
 						vrMovementMode: 1,
 						platform: 0,
-						appVersion: '20230302',
+						appVersion: GAME_VERSION,
 						expiresAt,
 					})
 				)
@@ -879,7 +880,7 @@ describe('auth-gated endpoints', () => {
 					deviceClass: 0,
 					vrMovementMode: 1,
 					platform: 0,
-					appVersion: '20230302',
+					appVersion: GAME_VERSION,
 					expiresAt: nowSeconds() + 800,
 				})
 			)