TheSunIsLeaking/recflare
3
0
Fork 0
mirror of https://github.com/djdevin/recflare.git synced 2026-10-26 23:48:52 -07:00
Code Issues Packages Projects Releases Wiki Activity

[rooms] fix slow engagement counters

Browse Source
This commit is contained in:
Devin Zuczek
2026-10-20 21:03:54 -04:00
parent 5f3cdc5922
commit affdcb85e3
4 changed files with 167 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/rooms/src/openapi.ts
+6 -5
View File
@@ -149,11 +149,12 @@ export const RoomTagDto = z.object({
})
/**
* A room's engagement counters. `CheerCount`/`FavoriteCount` are aggregated from the
* per-player `interaction` rows on every read. `VisitCount` is the room's lifetime
* visits — the `room.visits` column, bumped by the `match` worker on every successful
* matchmake into the room. Nothing records distinct visitors, so `VisitorCount` stays
* at 0.
* A room's engagement counters. `CheerCount`/`FavoriteCount` are the `room.cheers`/
* `favorites` columns, moved by the cheer/favorite toggles as they flip the per-player
* `interaction` row (so a count is how many players currently have the flag set).
* `VisitCount` is the room's lifetime visits — the `room.visits` column, bumped by the
* `match` worker on every successful matchmake into the room. Nothing records distinct
* visitors, so `VisitorCount` stays at 0.
*/
export const RoomStatsDto = z.object({
CheerCount: z.int(),
apps/rooms/src/test/integration/api.test.ts
+16 -1
View File
@@ -4769,7 +4769,7 @@ describe('rooms endpoints', () => {
expect(otherGet).toMatchObject({ Cheered: false, Favorited: false })
})
it('room Stats aggregate cheers/favorites from the interaction table', async () => {
it('room Stats count cheers/favorites on the room row, kept by the toggles', async () => {
type Stats = {
CheerCount: number
FavoriteCount: number
@@ -4818,6 +4818,21 @@ describe('rooms endpoints', () => {
VisitCount: 0,
})
// The counts are columns on the room, not an aggregate taken on read — the toggles
// keep them. A repeated clear changes nothing (the flag was already off), and neither
// does clearing a flag a player never set, so neither counts down again.
await interact('562', 'cheer', 'DELETE')
await interact('563', 'favorite', 'DELETE')
expect(await direct()).toMatchObject({ CheerCount: 1, FavoriteCount: 1 })
expect(
await env.DB.prepare('SELECT cheers, favorites FROM room WHERE room_id = 15').first()
).toEqual({ cheers: 1, favorites: 1 })
// Toggling off and on again lands back where it started.
await interact('561', 'cheer', 'PUT')
expect(await direct()).toMatchObject({ CheerCount: 0 })
await interact('561', 'cheer', 'PUT')
expect(await direct()).toMatchObject({ CheerCount: 1 })
// VisitCount is the `room.visits` column (what match bumps on each matchmake),
// served on every read of the room — here and in the search results — and it
// survives the cheer/favorite aggregation rather than being zeroed by it.